dashpay / dash-wallet

Dash Wallet for Android
https://dash.org
175 stars 169 forks source link

[NMA-1353] Coinbase loading dialog improvements #1013

Closed Syn-McJ closed 2 years ago

Syn-McJ commented 2 years ago

Improvements for the loading dialog showing time on the Convert screen. This PR includes #1009 to avoid conflicts.

Issue being fixed or feature implemented

Coinbase code seems to request the /accounts endpoint each time it needs something from it - I think there is an opportunity for caching and reusing the result. It will still be updated when a user opens buy/sell or the Coinbase portal and at some other times, but for deeper navigations, we might as well use the data we already have.

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

Checklist:

HashEngineering commented 2 years ago

This PR pulls in code from #1009 which has not been approved, it will be merged after #1009