[NMA-1396] Fingerprint scanner upgrade & fixes - Githubissues

dashpay / dash-wallet

Dash Wallet for Android

https://dash.org

175 stars 169 forks source link

[NMA-1396] Fingerprint scanner upgrade & fixes #1051

Closed Syn-McJ closed 2 years ago

Syn-McJ commented 2 years ago

To address various issues users have with the fingerprint scanner on the newer Android version, we want to upgrade to the modern biometrics package.

Issue being fixed or feature implemented

FingerprintManager is replaced with BiometricManager\Prompt from androidx.biometric
Shared view models in CheckPinDialog and descendants replaced with callbacks to simplify execution flow
Fingerprint flow is uncoupled from the CheckPinDialog (otherwise there are issues with displaying the fingerprint prompt)
Fixed LockScreen bug with the locked wallet status not being properly displayed during the first 10 seconds after opening

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

[ ] QA (Mobile Team)

Checklist:

[x] I have performed a self-review of my own code and added comments where necessary
[ ] I have added or updated relevant unit/integration/functional/e2e tests