feat(dashdirect): publish custom icons and gift cards to the Platform

dashpay / dash-wallet

Dash Wallet for Android

https://dash.org

173 stars 169 forks source link

feat(dashdirect): publish custom icons and gift cards to the Platform #1126

Closed Syn-McJ closed 1 year ago

Syn-McJ commented 1 year ago

In DashPay, we want to synchronize the custom transaction icons and gift card data with the Platform.

Issue being fixed or feature implemented

Created stubs for developing/testing DashDirect services on devnet
Added customIconUrl and gift card data to the tx metadata that is synced
Fixed Home navigation
Fixed reset wallet crash

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

[x] QA (Mobile Team)

Checklist:

[x] I have performed a self-review of my own code and added comments where necessary
[ ] I have added or updated relevant unit/integration/functional/e2e tests

HashEngineering commented 1 year ago

/home/runner/work/dash-wallet/dash-wallet/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/network/service/stubs/FakeDashDirectSendService.kt:32:2 Missing spacing before ":"
[77](https://github.com/dashpay/dash-wallet/actions/runs/5053718913/jobs/9067839587?pr=1126#step:6:77)
/home/runner/work/dash-wallet/dash-wallet/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/utils/DashDirectConstants.kt:23:5 Declarations and declarations with annotations should have an empty space between.

there is also a ktlint failure.

Syn-McJ commented 1 year ago

Ktlint complains about a rule that's excluded in the .editorconfig - not sure why. We can ignore this for now.