fix(uphold): wrong balance - Githubissues

dashpay / dash-wallet

Dash Wallet for Android

https://dash.org

173 stars 169 forks source link

fix(uphold): wrong balance #1140

Closed Syn-McJ closed 1 year ago

Syn-McJ commented 1 year ago

Seems like the issue with the incorrect balance is that we're taking the first DASH card we see, while there could be more than one.

Issue being fixed or feature implemented

Return a list of DASH cards from GetCards instead of the first card.
For the total balance, sum over all balances. For the active card, take the first one with balance or just the first one if all are empty.
Move Uphold from Moshi to Gson.

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

[ ] QA (Mobile Team)

Checklist:

[x] I have performed a self-review of my own code and added comments where necessary
[ ] I have added or updated relevant unit/integration/functional/e2e tests