data61 / GS1Combinators

A library to parse the GS1 Events into Haskell data types
Apache License 2.0
5 stars 1 forks source link

Include XML Snippets in ParseFailure #87

Closed sajidanower23 closed 5 years ago

sajidanower23 commented 5 years ago

At the moment, when something goes wrong, we just know that something was incorrect, not what was incorrect, which is not very helpful to the user.

Possible Fix

Include the URN in the error ParseFailure.

One problem I see with this is that user input is getting printed back to the user, which can sometimes turn out to be a security hole.

Original Author: ano002

(Moved with github-migration-0.1.0.0 (package github-migration-0.1.0.0 revision df9f38b))

sarafalamaki commented 5 years ago

Sending users input they've entered themselves is not generally a security risk. I think we should definitely add this information to the ParseFailure.

Original Author: fal05c