databricks / spark-deep-learning

Deep Learning Pipelines for Apache Spark
https://databricks.github.io/spark-deep-learning
Apache License 2.0
1.99k stars 494 forks source link

Fix KerasImageFileEstimator for model tuning #109

Closed yogeshg closed 6 years ago

yogeshg commented 6 years ago
yogeshg commented 6 years ago

#561.1 failed

PicklingError: Can't pickle <type 'function'>: attribute lookup builtin.function failed

#561.2 failed #561.3 failed

AttributeError: 'list' object has no attribute 'transform'

codecov-io commented 6 years ago

Codecov Report

Merging #109 into master will increase coverage by 0.78%. The diff coverage is 89.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   82.66%   83.45%   +0.78%     
==========================================
  Files          34       34              
  Lines        1990     1994       +4     
  Branches       44       44              
==========================================
+ Hits         1645     1664      +19     
+ Misses        345      330      -15
Impacted Files Coverage Δ
python/sparkdl/transformers/keras_image.py 100% <100%> (ø) :arrow_up:
python/sparkdl/transformers/tf_image.py 94.06% <100%> (-0.05%) :arrow_down:
python/sparkdl/param/image_params.py 77.5% <100%> (+1.82%) :arrow_up:
...n/sparkdl/estimators/keras_image_file_estimator.py 85.71% <88.63%> (+11.35%) :arrow_up:
src/main/scala/com/databricks/sparkdl/Models.scala 85% <0%> (ø) :arrow_up:
python/sparkdl/param/shared_params.py 85.32% <0%> (+1.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25e65d0...252408a. Read the comment docs.

yogeshg commented 6 years ago
yogeshg commented 6 years ago

@smurching thanks for the review and help offline!! I added the requested changes, and made a few comments to your questions.

yogeshg commented 6 years ago
yogeshg commented 6 years ago