tomasatdatabricks commented 6 years ago

We do not support Spark<2.3 anymore so there is no need for the copy-pasted ImageSchema file.

smurching commented 6 years ago

Let's also remove sparkdl.readImages & related methods ('imageSchema', 'imageType', 'readImages') from python/sparkdl/__init__.py? Otherwise LGTM

tomasatdatabricks commented 6 years ago

Good catch Sid. Thx!

codecov-io commented 6 years ago

Codecov Report

Merging #119 into master will increase coverage by 1.61%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   83.77%   85.38%   +1.61%     
==========================================
  Files          34       33       -1     
  Lines        1991     1923      -68     
  Branches       44       44              
==========================================
- Hits         1668     1642      -26     
+ Misses        323      281      -42

Impacted Files	Coverage Δ
python/sparkdl/__init__.py	`100% <ø> (ø)`	:arrow_up:
python/sparkdl/image/imageIO.py	`78.09% <100%> (ø)`	:arrow_up:
python/sparkdl/udf/keras_image_model.py	`73.8% <100%> (ø)`	:arrow_up:
python/sparkdl/transformers/tf_image.py	`94.06% <100%> (ø)`	:arrow_up:
python/sparkdl/param/image_params.py	`79.41% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfe9a7f...bb64503. Read the comment docs.

databricks / spark-deep-learning

Replaced copy-pasted image schema and all references with the original #119

Codecov Report