Closed lu-wang-dl closed 6 years ago
Merging #151 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 34 34
Lines 1922 1922
Branches 41 41
=======================================
Hits 1641 1641
Misses 281 281
Impacted Files | Coverage Δ | |
---|---|---|
python/sparkdl/transformers/keras_applications.py | 85.71% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6be7772...ef39c1e. Read the comment docs.
retest
Thanks for the update, Lu! As a summary of my comments:
model
and _testKerasModel
methods of resnet50?assertArrayAlmostEqual
to be introduced in a follow up prtensorframes
release to follow or precede this releaseLGTM pending tests. @jkbradley , LGTY?
LGTM too, thanks!
I'll merge this now. Thanks @ludatabricks and @yogeshg !
2.3.1
0.4.0
keras==2.2.2
andtensorflow==1.10.0
to fix travis issues2.3
and hence Scala2.10
pooling='avg'
in resnet50 testing model beccause keras api changedNamedImageTransformerBaseTestCase
,test_bare_keras_module
,keras_load_and_preproc
test_simple_keras_udf
This is a continued work from https://github.com/databricks/spark-deep-learning/pull/149.