search

databricks / spark-deep-learning

Deep Learning Pipelines for Apache Spark
https://databricks.github.io/spark-deep-learning
Apache License 2.0
2k stars 494 forks source link

Move Scalactic dependency to test only #152

Closed jkbradley closed 6 years ago

jkbradley commented 6 years ago

"org.scalactic" %% "scalactic" should only be needed in the test artifacts. This PR updates the build file to do that.

jkbradley commented 6 years ago

This should not conflict with https://github.com/databricks/spark-deep-learning/pull/151 but feel free to ignore this PR until the other PR is merged.

codecov-io commented 6 years ago

Codecov Report

Merging #152 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files          34       34           
  Lines        1922     1922           
  Branches       41       41           
=======================================
  Hits         1641     1641           
  Misses        281      281

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6be7772...0f8b258. Read the comment docs.

lu-wang-dl commented 6 years ago

LGTM. I tested locally. It is fine.