search

databricks / spark-deep-learning

Deep Learning Pipelines for Apache Spark
https://databricks.github.io/spark-deep-learning
Apache License 2.0
1.99k stars 494 forks source link

Remove persistence from DeepImageFeaturizer #161

Closed jkbradley closed 5 years ago

jkbradley commented 5 years ago

Until Apache Spark provides complete support for persistence in 3rd-party Python libraries, we need to remove this buggy implementation of persistence. Users have exported Pipelines with DeepImageFeaturizer, expecting to be able to import them back but finding they cannot.

codecov-io commented 5 years ago

Codecov Report

Merging #161 into master will decrease coverage by 0.1%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   85.37%   85.27%   -0.11%     
==========================================
  Files          34       34              
  Lines        1922     1908      -14     
  Branches       41       41              
==========================================
- Hits         1641     1627      -14     
  Misses        281      281
Impacted Files Coverage Δ
python/sparkdl/transformers/named_image.py 89.05% <100%> (-1.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16742e7...6fbbc45. Read the comment docs.

lu-wang-dl commented 5 years ago

LGTM