datalad / datalad-ebrains

DataLad extension to interface with the neuroinformatics platform of the Human Brain Project
Other
3 stars 5 forks source link

Template update #28

Closed mslw closed 2 years ago

mslw commented 2 years ago

This PR brings the extension up to date with the extension template. There are these major changes:

Other changes are mostly related to boilerplate code.

FTR, this was done with git merge --allow-unrelated-histories --squash. I did it in two stages, to see how much conflict resolution needs to be redone when changes are squashed. I don't have a precise record, but I feel that I had to repeat resolving some changes (mostly rejections), but not all, the amount of conflicts on the second part was reduced, as the diff was smaller.

TODO:

codecov[bot] commented 2 years ago

Codecov Report

Merging #28 (0118437) into master (957486a) will decrease coverage by 6.46%. The diff coverage is 23.61%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   44.88%   38.41%   -6.47%     
==========================================
  Files           5        5              
  Lines         127      164      +37     
==========================================
+ Hits           57       63       +6     
- Misses         70      101      +31     
Impacted Files Coverage Δ
datalad_ebrains/kg2ds.py 43.63% <7.69%> (-0.60%) :arrow_down:
datalad_ebrains/kg_query.py 26.31% <21.81%> (-5.36%) :arrow_down:
datalad_ebrains/__init__.py 100.00% <100.00%> (ø)
datalad_ebrains/_version.py 100.00% <100.00%> (ø)
datalad_ebrains/tests/test_register.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mslw commented 2 years ago

The only failing checks are from codecov, and they seem to be related to the actual extension code rather than the changed boilerplate. Since there aren't basically any tests, I would consider it a good sign, although someone might check whether there's some codecov configuration and whether it is done right.

mih commented 2 years ago

Thx!