search

datamade / nyc-council-councilmatic

NYC Council version of Councilmatic
MIT License
7 stars 3 forks source link

Rtf search #116

Closed reginafcompton closed 6 years ago

reginafcompton commented 6 years ago

This PR handles #104

reginafcompton commented 6 years ago

@hancush - we use a bill_text.txt file to communicate to Solr when preparing the text field for indexed bills. We want to use the ocr_full_text (poorly named variable) for this, not the full_text, which contains RTF.

fgregg commented 6 years ago

Can we rename the upstream field names so that it's less confusing?

reginafcompton commented 6 years ago

@fgregg - I'd love to make that happen. It's potentially a big issue, depending on how often the Councilmatic system uses ocr_full_text. (I'd also like to change full_text to rtf_text.) I would suggest that we assess how often we use these fields (e.g., in templates, views, solr logic....), and then decide how to prioritize this issue.

I've opened an issue for this in django-councilmatic.

I suggest we prioritize the NYC Post-launch milestone issue first, but let me know if you prefer otherwise.

fgregg commented 6 years ago

Agree with your prioritization @reginafcompton

reginafcompton commented 6 years ago

We'll need to rebuild the index to implement this fix. I turned off cron: then, I'll deploy, rebuild the index, and then turn on cron in another PR.