search

datamade / nyc-council-councilmatic

NYC Council version of Councilmatic
MIT License
7 stars 3 forks source link

Create "Filed - End of Session" status #118

Closed jeancochrane closed 6 years ago

jeancochrane commented 6 years ago

When a session ends, all bills with indeterminate status that were introduced during that session should receive the status "Filed - End of Session." This PR implements that change, and adds tests for a few different bill statuses.

Closes #112.

fgregg commented 6 years ago

This should be fixed upstream in the scraper.

reginafcompton commented 6 years ago

Can you say more @fgregg ?

fgregg commented 6 years ago

This is a piece of information about a bill, not a view about the bill. The OCD API should contain all the data we know about bills, including status.

reginafcompton commented 6 years ago

@jeancochrane - this looks beautiful overall! I only have a couple comments that need attention.

reginafcompton commented 6 years ago

@jeancochrane - ready to merge!