search

datamapio / posmo_one_testing

Public Testing Repo
0 stars 0 forks source link

Partly Validation #26

Open thohug opened 3 years ago

thohug commented 3 years ago

Partly Validation is possible without notice even if the day hasn't ended yet. Validation can't be undone later on.

grafik

djr4 commented 3 years ago

Wait, you were able to validate even today? Ok that must be a bug. For other days you should be able to validate partial days (even if days do not end) by change request (but we should reward less Ostroms for that day)

In profile were you not able to delete wrongly validated day? (This should be live in production)

thohug commented 3 years ago

Ah sorry, yes I was able to validate, bus also to delete. I didnt find the respective entry as the days aren't ordered by date in my case...

grafik

Deleting worked. Validation is now again possible for today...

grafik

djr4 commented 3 years ago

Ok so 2 things:

  1. prevent validation on current day (this is a bug for sure)
  2. sort validated days by date

Thanks for reporting, will let you know when I resolve this.

djr4 commented 3 years ago

Ok resolved both issues. Will be in next release (hopefully today if I manage to implement coop mobility bar chart so we can look at aggregated coop commons data) - distribution over transport modes.

rogerfischer commented 3 years ago

@djr4 Should we call this "Revoke" resp. "Revoke Validation" instead of "Delete"?

djr4 commented 3 years ago

Sure, I add this into this release as well. 🙂

On Tue, 24 Nov 2020 at 15:04, Roger notifications@github.com wrote:

@djr4 https://github.com/djr4 Should we call this "Revoke" resp. "Revoke Validation" instead of "Delete"?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/datamapio/posmo_one_testing/issues/26#issuecomment-732993496, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQORJC3IYCWUIQG3FNAH63SRO4PFANCNFSM4UAWIPKA .