Punch list - Githubissues

datawire / tour

0 stars 1 forks source link

Punch list #1

Open richarddli opened 5 years ago

richarddli commented 5 years ago

[x] Need a way to escape YAML used in the docs (see RateLimitingAction.js for an example)
[x] Next/previous buttons on the page
[x] Add HubSpot trial signup form to AmbassadorPro.js
[x] Rate limiting page add button to start/stop sending HTTP requests to /backend URL
[x] Update MultiPlatform.js to include the image ambassador-consul.png
[x] Make text look good

kelseyevans commented 5 years ago

Use the following for HubSpot trial signup form (clone of other page):

dansipple commented 5 years ago

@richarddli For escaping yaml, I added a css style for code blocks. You can add more blocks of yaml like:

  <div className="code-block">
      <pre>
        <code>
    {
`---
apiVersion: v1
kind: Service
metadata:
  name: tour
  annotations:
    getambassador.io/config: |
      ---
      apiVersion: ambassador/v1
      kind:  Mapping
      name:  tour_mapping
      prefix: /tour/
      service: tour
spec:
  ports:
    - name: http
      port: 80
`}
        </code>
    </pre>
  </div>

The yaml itself should be escaped as a string using backticks ``

dansipple commented 5 years ago

Hey Richard, I just pushed up changes to the rate-limiting graph. I'm not really sure how to set the backend up, so I don't have an endpoint to test against, but as far as I can test it groups and counts the error codes accordingly. Let me know if there is anything else you want to add/remove.