datduong / NLPMethods2CompareGOterms

Natural language processing methods to compare 2 Gene Ontology terms
5 stars 2 forks source link

Error in Main Script #1

Open TaoDFang opened 6 years ago

TaoDFang commented 6 years ago

Hi Guys,

Indeed you did a great job for GO term comparison. However, I notice there are some grammatical error in your main script "compare2GO.py"(line 122-127): image

And in "classifier.py", what is "nn_layer" module ? I can not find it on the website.

Best, Tao

datduong commented 6 years ago

Hi Tao,

Thanks for trying out the code. You're correct, it was an error. I removed the else on line 123. Originally, I didn't have args.all3 , so this part was lumped into the if-else immediately before it.

The nn_layer.py was in Wasi's code. I just now added this file into this current github. Thanks for catching this 2nd error.