dativebase / old-pyramid

Online Linguistic Database (OLD)
http://www.onlinelinguisticdatabase.org/
8 stars 2 forks source link

Default session secure attribute to true #59

Closed jrwdunham closed 2 years ago

jrwdunham commented 2 years ago

Ensure that the cookies sent by the OLD have the secure attribute set by default. This can still be disabled by setting the env var 'OLD_SESSION_SECURE' to 'false', or by modifying config.ini directly.

Rationale

Modern browsers now require HTTPS to be used and the secure flag enabled in order to use samesite=None, which is what Dative/OLD does because we want to allow cross-origin requests that are authorized via cookie sessions.