Tempo fixes for live sequencer

datomusic / duo-imxrt

MIT License

3 stars 0 forks source link

Tempo fixes for live sequencer #135

Closed ggVGc closed 1 year ago

ggVGc commented 1 year ago

https://github.com/datomusic/duo-imxrt/pull/114 introduced some weird behaviours for midi sync. This PR simplifies the midi sync source and source detection and should fix the issues.

ggVGc commented 1 year ago

This branch now has correct handling of external sync over usb-midi and sync cable, as far as I can tell. I have not tested midi-cable yet, but it should work the same as USB-MIDI I believe, since nothing should be different in that regard compared to main.

I can still see it sometimes exhibiting https://github.com/datomusic/duo-imxrt/issues/138, but since this is also an issue on main I think it's not to be fixed in this PR.

DavidMenting commented 1 year ago

Timing seems tight and half/normal/double/quad works nicely. However I do see the following timing-related issue:

[ ] When sending a MIDI start message the first note is not played (DIN/USB)