search

datopian / datahub

🌀 Rapidly build rich data portals using a modern frontend framework
https://datahub.io/opensource
MIT License
2.17k stars 322 forks source link

[remark-wiki-link][m]: Add image size adjustment in `remark-wiki-link` #1084

Closed mohamedsalem401 closed 1 month ago

mohamedsalem401 commented 3 months ago

For https://github.com/datopian/flowershow/issues/592

We add width and height to img tags, and also we add inline styling for the width and the height of the image.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: af0b4de3c1bee99045fbe39137ef0c06afa04b2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------- | ----- | | @portaljs/remark-wiki-link | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

9 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **portaljs-alan-turing** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-alan-turing/nSLaMxBveAXJojvWt7pj8iUAfqKH)) | [Visit Preview](https://portaljs-alan-turing-git-image-size-datopian1.vercel.app) | | Apr 1, 2024 11:45am | | **portaljs-ckan** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-ckan/22zsQL2eCQHQRwM5qeq7LQr8DfVU)) | [Visit Preview](https://portaljs-ckan-git-image-size-datopian1.vercel.app) | | Apr 1, 2024 11:45am | | **portaljs-ckan-ssg** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-ckan-ssg/x3ea1nec7snCBfXPVwafNbLV9yU8)) | [Visit Preview](https://portaljs-ckan-ssg-git-image-size-datopian1.vercel.app) | | Apr 1, 2024 11:45am | | **portaljs-fivethirtyeight** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-fivethirtyeight/DWHgfvdTviBwg3eKgmG4fJmF3rVN)) | [Visit Preview](https://portaljs-fivethirtyeight-git-image-size-datopian1.vercel.app) | | Apr 1, 2024 11:45am | | **portaljs-git-example** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-git-example/AoKzHLrmtLz6zoLyaBqNAXD6sdS1)) | [Visit Preview](https://portaljs-git-example-git-image-size-datopian1.vercel.app) | | Apr 1, 2024 11:45am | | **portaljs-learn** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-learn/4JPwFThKXVkYoBxp2X5rBj6gmReX)) | [Visit Preview](https://portaljs-learn-git-image-size-datopian1.vercel.app) | | Apr 1, 2024 11:45am | | **portaljs-openspending** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-openspending/Dd2q4Djgz3E8Di6Qfyv7HQTtc1Uo)) | [Visit Preview](https://portaljs-openspending-git-image-size-datopian1.vercel.app) | | Apr 1, 2024 11:45am | | **portaljs-storybook** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-storybook/5gjXnNF3F228hHioAGcE1eRRxtxV)) | [Visit Preview](https://portaljs-storybook-git-image-size-datopian1.vercel.app) | | Apr 1, 2024 11:45am | | **site-portaljs** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/site-portaljs/9gvGecRyq9dbHob3MQ9Br4MvC9zH)) | [Visit Preview](https://site-portaljs-git-image-size-datopian1.vercel.app) | | Apr 1, 2024 11:45am |
olayway commented 3 months ago

@mohamedsalem401 Please remember to add a changeset file :)

rufuspollock commented 1 month ago

@mohamedsalem401 can you do quick tweaks so we can get this merged.

mohamedsalem401 commented 1 month ago

@rufuspollock Sure, I will work on this on Monday.

mohamedsalem401 commented 1 month ago

@rufuspollock @olayway I updated the PR.

All tests are running correctly.