search

datopian / datahub

🌀 Rapidly build rich data portals using a modern frontend framework
https://datahub.io/opensource
MIT License
2.17k stars 322 forks source link

Allow children in mobile nav #1086

Open homostellaris opened 3 months ago

homostellaris commented 3 months ago

Adds some finishing touches to @olayway's work to allow the mobile nav to render arbitrary children which can be useful for things like site-wide navigation.

Also adds some stories to demonstrate the new functionality and migrates to the Storybook NextJs 'framework' which allows the Nav component to be rendered in a story with all the routing automatically stubbed and taken care of.

https://github.com/datopian/portaljs/assets/15190231/2f3a2d4d-6396-4035-9b3e-e7bf01ccca69

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 7b38ce1b1a77a409da238623b1f63ba8eb230767

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **portaljs-alan-turing** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-alan-turing/BKDBiT2uE8SVFTKupahKpnYHH3Pe)) | [Visit Preview](https://portaljs-alan-turing-git-fork-homostellaris-al-9e90d3-datopian1.vercel.app) | | Feb 17, 2024 8:47am | | **portaljs-ckan** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-ckan/AmGyD44kb3FMtQMCJysJUyrMMY6Y)) | [Visit Preview](https://portaljs-ckan-git-fork-homostellaris-allow-chi-b4ddda-datopian1.vercel.app) | | Feb 17, 2024 8:47am | | **portaljs-git-example** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-git-example/B9MsLaYYmD3Dgf4ia4JytbZfYe3W)) | [Visit Preview](https://portaljs-git-example-git-fork-homostellaris-al-6e6fe4-datopian1.vercel.app) | | Feb 17, 2024 8:47am | | **portaljs-learn** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-learn/DCdabghKG26YTiv767LayAxLBGKg)) | [Visit Preview](https://portaljs-learn-git-fork-homostellaris-allow-ch-09b4c5-datopian1.vercel.app) | | Feb 17, 2024 8:47am | | **portaljs-storybook** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-storybook/Cf8HbpaAFBswxwcHYuDZox8q1HTa)) | [Visit Preview](https://portaljs-storybook-git-fork-homostellaris-allo-ea3e95-datopian1.vercel.app) | | Feb 17, 2024 8:47am | | **site-portaljs** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/site-portaljs/DZSyky8k1Fnz1uxd4mo1uarb8M9Z)) | [Visit Preview](https://site-portaljs-git-fork-homostellaris-allow-chi-102c2e-datopian1.vercel.app) | | Feb 17, 2024 8:47am |
vercel[bot] commented 3 months ago

@homostellaris is attempting to deploy a commit to the Datopian Team on Vercel.

A member of the Team first needs to authorize it.

homostellaris commented 3 months ago

Accidentally added some reformatting there, will tidy that up shortly

homostellaris commented 3 months ago

Diff is cleaned up now, looks like I need authorization to pass some checks though?

homostellaris commented 3 months ago

@Gutts-n sorry to @ you but any idea what I can do to get this merged? Myself and many others would love this to enable mobile site-wide table of contents for Flowershow.

Gutts-n commented 3 months ago

Hello @homostellaris you could request @olayway to make the CR, and your PR doesn't have a changeset, you need to run npx changeset in the main folder of the project and select to be a minor bump with a comment about the functionality implemented, after it you push these changeset's files to your branch and it'll be good to us make the CR and merge.

Screenshot_2024-02-16-20-28-11-965_com.github.android.jpg

homostellaris commented 3 months ago

Thanks @Gutts-n, I've added the changeset, my bad for not reading the contribution docs properly!

@olayway if you could take a look at this would be awesome 🙏

homostellaris commented 3 weeks ago

Any way to progress this? Totally understand if this isn't a priority but just to provide honest feedback, I'll have to eventually migrate away from Flowershow if the open source community isn't active 🙏