search

datopian / datahub

🌀 Rapidly build rich data portals using a modern frontend framework
https://datahub.io/opensource
MIT License
2.17k stars 322 forks source link

Components API and docs improvements #1103

Closed demenech closed 1 month ago

demenech commented 1 month ago

Related to: https://github.com/datopian/datahub/issues/1089

Changes

I tried to make commits very granular so it's easy to figure out what changed based on the commit history.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 48cd812a488a069a419d8ecc67f24f94d4d1d1d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @portaljs/components | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portaljs-alan-turing 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 2:15pm
8 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **portaljs-ckan** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-ckan/BDrpP2281GHfX1CJftBYXDEEtksq)) | [Visit Preview](https://portaljs-ckan-git-feat-portaljs-components-imp-489b7d-datopian1.vercel.app) | | Apr 17, 2024 2:15pm | | **portaljs-ckan-ssg** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-ckan-ssg/4SjWj3hYURbGNxAs4Kj9ZmBts1rb)) | [Visit Preview](https://portaljs-ckan-ssg-git-feat-portaljs-components-776ca2-datopian1.vercel.app) | | Apr 17, 2024 2:15pm | | **portaljs-fivethirtyeight** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-fivethirtyeight/FHSsnxpNjWGAGC27CCg7sUzb7ji5)) | [Visit Preview](https://portaljs-fivethirtyeight-git-feat-portaljs-com-d67343-datopian1.vercel.app) | | Apr 17, 2024 2:15pm | | **portaljs-git-example** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-git-example/H1huBabq2ya8BkB5rcs8TMn79rqq)) | [Visit Preview](https://portaljs-git-example-git-feat-portaljs-compone-17235b-datopian1.vercel.app) | | Apr 17, 2024 2:15pm | | **portaljs-learn** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-learn/6otm7BYct6TndUJGtzs66XJ2ETh1)) | [Visit Preview](https://portaljs-learn-git-feat-portaljs-components-im-cc08f4-datopian1.vercel.app) | | Apr 17, 2024 2:15pm | | **portaljs-openspending** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-openspending/9dP9y3y1oRu8t5KLzhxju9upopyv)) | [Visit Preview](https://portaljs-openspending-git-feat-portaljs-compon-585c9b-datopian1.vercel.app) | | Apr 17, 2024 2:15pm | | **portaljs-storybook** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/portaljs-storybook/8HsQcNkhpSfxQwvXPk1DkCBLadrg)) | [Visit Preview](https://portaljs-storybook-git-feat-portaljs-component-d305d9-datopian1.vercel.app) | | Apr 17, 2024 2:15pm | | **site-portaljs** | ⬜️ Ignored ([Inspect](https://vercel.com/datopian1/site-portaljs/5252JqQRZyf4n2E1zpAZbwgt3jgo)) | [Visit Preview](https://site-portaljs-git-feat-portaljs-components-imp-7b00a7-datopian1.vercel.app) | | Apr 17, 2024 2:15pm |
rufuspollock commented 1 month ago

@olayway from a quick look this looks great and a good tidy-up. do you want to have a quick look through and if looks ok we can merge.

olayway commented 1 month ago

Great job @demenech! This is exactly what we needed! Thank you! 🌻