datopian / datahub

🌀 Rapidly build rich data portals using a modern frontend framework
https://www.portaljs.org
MIT License
2.2k stars 328 forks source link

Replace "Powered by DataHub" with "Built with DataHub" and add a hyperlink #1247

Closed popovayoana closed 3 months ago

popovayoana commented 3 months ago

Description

We need to replace the text "Powered by DataHub" with "Built with DataHub" and ensure that this text is clickable, redirecting users to https://datahub.io/ on all dataset/PKM pages generated with DataHub Cloud (e.g. https://datahub.io/@TyuninaA/city-ranking).

Expected Behavior

Screenshot

Image Source: https://datahub.io/@davidgasquez/handbook

willy1989cv commented 3 months ago

@popovayoana I want to start shaping this issue. is the "Powered by DataHub" in footer you are refering? image

popovayoana commented 3 months ago

@willy1989cv i've added a short description, please have a look - it's ready to be shipped, no need for shaping.

willy1989cv commented 3 months ago

@popovayoana I'm on it! One question: should the link open in same tab, or open a new one?

popovayoana commented 3 months ago

@willy1989cv a new one

willy1989cv commented 3 months ago

@popovayoana I was thinking, imagine we are in the datahub.io/collections, does it make sense to open in a new tab?

popovayoana commented 3 months ago

we already synced in chat but quick update: acc to web accessibility, having links open in a new tab or window is usually considered inaccessible + in our case, the footer component is the same across the website (e.g. dataset page footer is the same component as home page footer) so we're going with same tab. https://www.w3.org/TR/WCAG20-TECHS/G200.html

olayway commented 3 months ago

FIXED