search

datopian / datahub

🌀 Rapidly build rich data portals using a modern frontend framework
https://datahub.io/opensource
MIT License
2.18k stars 322 forks source link

Updates/branch for Bootstrap v3 #427

Closed marks closed 9 years ago

marks commented 10 years ago

I am working to integrate recline.js into a bootstrap 3 project and it is definitely going to require some work. Wondering if anyone else has already done this or where the appropriate place to document changes (probably a new branch) would be.

rufuspollock commented 10 years ago

@marks don't believe anyone is working on this and would be very welcome. Would definitely suggest having a branch forked off master.

rufuspollock commented 9 years ago

@marks let me know how this is going - would be delighted to get this in - branch is probably best approach in first instance.

marks commented 9 years ago

Sorry I dropped the ball on this one - hope to revisit it this week and see what needs to be done to get going on this!

marks commented 9 years ago

@rgrp here's a start at least. a lot to do!

rufuspollock commented 9 years ago

@marks how is this going? is this good to merge? Also is this in its own branch or will it go against master?

marks commented 9 years ago

@rgrp I was working in a branch: https://github.com/marks/recline/tree/upgrade-bootstrap-to-3.2.0 - work is definitely not done and I'm swamped if anyone else is wanting to work on it too

rufuspollock commented 9 years ago

@marks what's outstounding here? It would be useful to know for others to help out ...

marks commented 9 years ago

@rgrp pretty much everything other than what I've done which is just to begin on the data filters and paging is left to do.

acouch commented 9 years ago

We are going to try and pitch in on this using @marks stopping off point. Will report back when we have a PR.

ghost commented 9 years ago

I've sent a PR for upgrading Bootstrap to v3. I included a lot of changes implemented by @marks on his branch but forked from okfn/recline to start with everything up to date.