Updating Extensions

[gotjoshua]

Greetings, I am beginning to develop a fork of timemapper, and I feel like this first step is to get the libraries up to date. Is there anyone working on Recline actively enough that you could update leaflet and timelineJS to their most recent versions? Or possibly to add an alternative extension with timelineJS3 and leaflet Beta1? Thanks for your amazing work so far!

[mattfullerton]

Leaflet should be fairly recent. Would you be able to clone a copy of recline, replace the existing libraries with the newest/relevant versions and give us some feedback on whether everything works? In particular by running a webserver based in the root folder and browsing to /demo and /test? Let me know if you need support.

[gotjoshua]

Looks like recline is at the most recent release of leaflet (but they are offering a beta of 1.0) and i'd like to start out my project on up to date libraries.

i can set up a subdomain that uses the recline root folder at its root html folder. and i will try to swap in the beta libraries to have a look.

I am a quite experienced flash/flex and javascript/html developer - but new to git and github so, yeah, i may need some support...

My wish is to use recline as a submodule in TimeMapper... and if possible TimeLineJS3 as a submodule in recline... does this seem reasonable to you?

~ .:.joshua "Life is a series of gestures, into which we embed meaning..."

"The fear of being free makes us proud to be slaves."

"Morality is doing what is right regardless of what you are told. Obedience is doing what you are told regardless of what is right"

On Wed, Aug 19, 2015 at 4:15 PM, Matt Fullerton notifications@github.com wrote:

Leaflet should be fairly recent. Would you be able to clone a copy of recline, replace the existing libraries with the newest/relevant versions and give us some feedback on whether everything works? In particular by running a webserver based in the root folder and browsing to /demo and /test? Let me know if you need support.

— Reply to this email directly or view it on GitHub https://github.com/okfn/recline/issues/487#issuecomment-132634855.

[mattfullerton]

That seems reasonable enough, but I'm biased as I like to see people using Recline. I haven't yet understood the relationship between Recline's timeline view and TimeMapper, perhaps there isn't any except for some common js library, but overall adding the ability to use one view as a controller for which other views to show (which I think is roughly what you're trying to do), seems like a really nice feature in line with Recline's aim of making building data-based applications easy.

[gotjoshua]

so, seems like updating to the timelinejs3 does not pass the tests: http://recline.1zm.in/test/

i simply added my fork of timelineJS3 as a submodule to my fork of recline (added a symlink to the /compiled directory as recline/vendor/timeline) and tried to run it. At first i got an error that VMM was undefined on line 31 and saw in the timeline.js a reference to VCO but not VMM... so i changed VMM to VCO, and it seemed to get one step closer to initilizing, but now throws the error that you see (http://recline.1zm.in/test/): Source:

TypeError: Cannot read property 'offsetHeight' of null at VCO.Timeline.VCO.Class.extend.initialize (http://recline.1zm.in/vendor/timeline/js/timeline.js:11363:35) at new NewClass (http://recline.1zm.in/vendor/timeline/js/timeline.js:2234:20)

I must say I am not familiar enough with these libraries yet to offer any meaningful feedback... but if i set things up right, then at least i can say it doesn't appear to work "out of the box"

and http://recline.1zm.in/ http://recline.1zm.in/test/demo seems to redirect to /app which does not exist...

cheers!

~ .:.joshua "Life is a series of gestures, into which we embed meaning..."

"The fear of being free makes us proud to be slaves."

"Morality is doing what is right regardless of what you are told. Obedience is doing what you are told regardless of what is right"

On Wed, Aug 19, 2015 at 9:58 PM, Matt Fullerton notifications@github.com wrote:

That seems reasonable enough, but I'm biased as I like to see people using Recline. I haven't yet understood the relationship between Recline's timeline view and TimeMapper, perhaps there isn't any except for some common js library, but overall adding the ability to use one view as a controller for which other views to show (which I think is roughly what you're trying to do), seems like a really nice feature in line with Recline's aim of making building data-based applications easy.

— Reply to this email directly or view it on GitHub https://github.com/okfn/recline/issues/487#issuecomment-132781696.

[gotjoshua]

Hi again, I got this reply from Joe over at TimelineJS: https://github.com/NUKnightLab/TimelineJS3/issues/202#issuecomment-132987860

Let me know if you have ideas for how to proceed...

I would love to have a version of recline working with the timelineJS3 beta and the leaflet1.0 beta... Is this a dev priority for your project? Do you guys have the resources to make it happen any time soon?

cheers, joshua

[mattfullerton]

I think upgrading to leaflet 1.0beta will happen at some point, probably when it isn't beta anymore. As for timelineJS3, I can't make any promises at all - I've hardly worked with the timeline component at all and I don't see any other Recline users (we have a lot of watchers) chiming in here either :-(

We have, afaik, hardly any resources. I have had the chance to do some minor bug fixing, cleaning, documenting and upgrading of libraries in recent months because of both my job last year and my job this year needing Recline to work well. But my work has much more to do with the Data Explorer and graphing/mapping stuff than the timeline component.

One option, which probably isn't very attractive, is to start from scratch and write a new view (http://okfnlabs.org/recline/docs/views.html) - or rather, cut the current timeline view to the very minimum possible to get something basic to work and then work from there.

Also, with the site/urls not working - the site is built with jekyll and needs to be compiled first to static html.

[rufuspollock]

To note for my part: I think that as per https://github.com/okfn/recline/issues/376 we want to split views especially e.g. timeline out to their own repos and we actually started on this https://github.com/okfn/recline.view.timeline (bare bones and empty atm) and want to complete. That would also make upgrading and discussions about it easier. @gotjoshua if you were interesting in helping complete that refactor (ie. the timeline view in a separate repo) we could definitely support you.

[gotjoshua]

Hey guys, This all sounds great, and I am somehow interested... however, i think you may spend more time holding my hand then it would take you to simply get 'er done.

Idea would be to bring in recline.view.timeline https://github.com/okfn/recline.view.timeline as a submodule to the main recline branch?

As a side question: Are any of the devs who made/maintain recline also involved in timemapper?

cheers,

~ .:.joshua "Life is a series of gestures, into which we embed meaning..."

"The fear of being free makes us proud to be slaves."

"Morality is doing what is right regardless of what you are told. Obedience is doing what you are told regardless of what is right"

On Fri, Aug 21, 2015 at 10:26 AM, Rufus Pollock notifications@github.com wrote:

To note for my part: I think that as per #376 https://github.com/okfn/recline/issues/376 we want to split views especially e.g. timeline out to their own repos and we actually started on this https://github.com/okfn/recline.view.timeline (bare bones and empty atm) and want to complete. That would also make upgrading and discussions about it easier. @gotjoshua https://github.com/gotjoshua if you were interesting in helping complete that refactor (ie. the timeline view in a separate repo) we could definitely support you.

— Reply to this email directly or view it on GitHub https://github.com/okfn/recline/issues/487#issuecomment-133347719.

[rufuspollock]

@gotjoshua yes i built timemapper and i was one of the leadings devs on recline. I've recently had less time for development work ;-) but I still get involved and am available to help or mentor new contributors.

[gotjoshua]

Do you want to create a new public folder in the recline/src folder (for remote submodules) or do you prefer to bring in the files one by one from the separate repo?

~ .:.joshua "Life is a series of gestures, into which we embed meaning..."

"The fear of being free makes us proud to be slaves."

"Morality is doing what is right regardless of what you are told. Obedience is doing what you are told regardless of what is right"

On Fri, Aug 21, 2015 at 11:20 AM, Rufus Pollock notifications@github.com wrote:

@gotjoshua https://github.com/gotjoshua yes i built timemapper and i was one of the leadings devs on recline. I've recently had less time for development work ;-) but I still get involved and am available to help or mentor new contributors.

— Reply to this email directly or view it on GitHub https://github.com/okfn/recline/issues/487#issuecomment-133364813.

[gotjoshua]

Some progress: I added TimelineJS2 and TimelineJS3 as submodules into my recline fork: https://github.com/gotjoshua/recline/tree/master/vendor

the test is live here: http://recline.1zm.in/test/

Test 61 & 63 passed so that is a start..

but test 62 for rendering failed, but I can't quite figure out why... seems like the selector is not found... any pointers?

~ .:.joshua "Life is a series of gestures, into which we embed meaning..."

"The fear of being free makes us proud to be slaves."

"Morality is doing what is right regardless of what you are told. Obedience is doing what you are told regardless of what is right"

On Fri, Aug 21, 2015 at 1:51 PM, .:.joshua gottdenker gotjoshua@gmail.com wrote:

Do you want to create a new public folder in the recline/src folder (for remote submodules) or do you prefer to bring in the files one by one from the separate repo?

~ .:.joshua "Life is a series of gestures, into which we embed meaning..."

"The fear of being free makes us proud to be slaves."

"Morality is doing what is right regardless of what you are told. Obedience is doing what you are told regardless of what is right"

On Fri, Aug 21, 2015 at 11:20 AM, Rufus Pollock notifications@github.com wrote:

@gotjoshua https://github.com/gotjoshua yes i built timemapper and i was one of the leadings devs on recline. I've recently had less time for development work ;-) but I still get involved and am available to help or mentor new contributors.

— Reply to this email directly or view it on GitHub https://github.com/okfn/recline/issues/487#issuecomment-133364813.

[gotjoshua]

Hi Again, I's also like to call your attention to: https://github.com/okfn/timemapper/issues/179

cheers...

[gotjoshua]

@rgrp, you offered help/mentoring, and I'd like to take you up on that. maybe we ought to close this initial issue and start a series of more concise issues. eg:

• Refactor TimelineJS (both 2 and 3 & both the recline view and the vendor js) as external submodules
• Test Leaflet Beta1
• add Mapbox view (also as external submodule - using mapbox standalone)
• add geojson.io view (that can attach to main mapbox view)

so far... please let me know your thoughts and your availability for mentoring...

thanks, gotjoshua

[rufuspollock]

@gotjoshua apologies - i somehow missed these issues when you first posted.

Basically we want to split the timeline recline view out into a separate repo as per #376. That would mean moving view code there - we might need to submodule in recline "main" to start with to get everything working and then go from there - we really won't want to be submoduling in massive external dependencies into recline core. I can maybe have a stab at getting this up and running now and then you can continue it.

On other items you've got a bunch of excellent suggestions e.g. mapbox and geojson.io sound great. I assume they do not specifically relate to the timeline view but are more general things we'd like to have in recline. Perhaps you could open a specific issue for each of them and we go from there.

[gotjoshua]

sounds great.

agreed they are more general things, but you will notice that most "general" things that I am suggesting are quite specific to getting timemapper up to date and customized for my needs. which i am managing to make quite some progress already: https://github.com/okfn/timemapper/issues/179#issuecomment-138075744

[rufuspollock]

@gotjoshua i did not manage to make much progress factoring out the timeline view though it is still the plan ;-) Are you keen to see this happen and/or help out? If so, let me know!

[rufuspollock]

@gotjoshua the recline view is now factored out https://github.com/okfn/recline.view.timeline :smile: (much easier than I thought). If we wanted to start patching it and updating vender deps we can do so there outside of core recline!

[rufuspollock]

FIXED / INVALID. This is now in recline.view.timeline.