Obsidian Wiki remark plugin should export node type

datopian / datahub

🌀 Rapidly build rich data portals using a modern frontend framework

https://www.portaljs.org

MIT License

2.21k stars 328 forks source link

Obsidian Wiki remark plugin should export node type #975

Open ShravanSunder opened 1 year ago

ShravanSunder commented 1 year ago

This would make it easier to use the library with unist

rufuspollock commented 1 year ago

@ShravanSunder thanks for the feedback. Could you tell us a bit more about how we should do that ...

ShravanSunder commented 1 year ago

This is the line right here, where its created and defined as an object. There should be a typescript type for this that's exported. It would make it much easier to use this for parsing with uinst and mdast. 🙇🏾

https://github.com/datopian/portaljs/blob/b940c82d93e6537b237f4f9500ba47c1367a7bcb/packages/remark-wiki-link/src/lib/fromMarkdown.ts#L46-L59

rufuspollock commented 1 year ago

@ShravanSunder thanks - would you be up for doing a pull request? 😄