search

dattalab-6-cam / multicamera_acquisition

Synchronized machine vision acquisition across multiple cameras using an arduino (Supports FLIR and Basler)
MIT License
4 stars 5 forks source link

azure recording kwarg is misleading #10

Closed jonahpearl closed 6 months ago

jonahpearl commented 9 months ago

We're using the azure_recording kwarg in acquire_video() to check a few things related to frame rates...let's just ask whether there's an azure in the camera list instead. It doesn't actually control whether or not an azure recording happens, which is what it implies.

jonahpearl commented 9 months ago

The reason I don't just change this myself is because this line makes me think it's interacting with the arduino code in an odd way...but I think the feature this line is hinting at isn't implemented yet (having the arduino understand a num cycles wrt the basler frame rate instead of the azure frame rate)? so can we just squash that feature for now and implement it later?

calebweinreb commented 6 months ago

Can we close this? Seems resolved