search

dattalab-6-cam / multicamera_acquisition

Synchronized machine vision acquisition across multiple cameras using an arduino (Supports FLIR and Basler)
MIT License
4 stars 5 forks source link

Arduino refactor #27

Closed calebweinreb closed 7 months ago

jonahpearl commented 8 months ago

I resolved conflicts arising from #25 and #29, all tests passing. @calebweinreb, can you please write some unit tests for the microcontroller.py code, e.g. in /tests/interfaces/test_microcontroller.py?

One should have to opt-in to running the tests with some pytest flag like runmcu (see how @kaijfox did this for rungui in tests/visualization/conftest.py).

Tests I could imagine include: -- make sure it finds a connected arduino -- make sure it rejects bad pin sequences in various ways -- a full test of refactor_acquire_video() with the mcu configured as desired.

And then also what you wrote in the 6cam channel, ie testing the inputs get written to a file.

Thanks!

jonahpearl commented 8 months ago

Also this might be a good time for @timsainb to jump in with the code to read in the random sync bit changes from the cameras. Maybe don't do it on this PR, but starting from this branch (arduino-refactor) makes sense as a starting point.