search

dattalab-6-cam / multicamera_acquisition

Synchronized machine vision acquisition across multiple cameras using an arduino (Supports FLIR and Basler)
MIT License
5 stars 5 forks source link

Remove input pins from "Turn off all digital pins for safety at the end" #42

Open timsainb opened 8 months ago

timsainb commented 8 months ago

Does anyone have a problem with me excluding input pins from this line:

https://github.com/dattalab-6-cam/multicamera_acquisition/blob/main/microcontroller_firmware/trigger_io/trigger_io.ino#L407C1-L412C14

// Turn off all digital pins for safety at the end
for (int i = 0; i < NUM_DIGITAL_PINS; i++)
{
    pinMode(i, OUTPUT);
    digitalWrite(i, LOW);
}

The issue being that when you have a second device monitoring the same input, it only works if the cameras are rolling.

For me a Fed3 is simultaneously being listened to by the teensy, a raspberry pi, and a nidaq board, and this line is messing with that.

jonahpearl commented 8 months ago

Makes sense to me. If it's an input pin we shouldn't force it to have one voltage or the other.