search

dattalab-6-cam / multicamera_acquisition

Synchronized machine vision acquisition across multiple cameras using an arduino (Supports FLIR and Basler)
MIT License
5 stars 5 forks source link

video_codec from writer config is never used #49

Closed calebweinreb closed 7 months ago

calebweinreb commented 7 months ago

Can we remove "video_codec" from the writer config? There are three lines that instantiate it but then it is never actually used

(e.g. https://github.com/dattalab-6-cam/multicamera_acquisition/blob/68682c5ef707847ea6de731ecef34723837fea9e/multicamera_acquisition/writer.py#L585)

calebweinreb commented 7 months ago

Addressed by https://github.com/dattalab-6-cam/multicamera_acquisition/commit/23bb6751534aed20c7f7d4902f9f56eddcd354c2