search

david-fisher / 320-F21-Track-1

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Cleanup and combine Team Team and te4m code #95

Closed tomking closed 2 years ago

tomking commented 2 years ago

The stateobject-cleanup branch contains the semi-finalized combination of Team Team and Te4m's code. Persisted object classes are found in src/Objects and runtime-only object classes can be found in src/State.

tomking commented 2 years ago

Alright, @ygbull we removed te4m's demo file. It shouldn't be needed anymore. Does Team Team still need that old demo file @SiegAndy @sasana-uwu ?

tomking commented 2 years ago

@ygbull Yeah that isn't our team's file, it is possible that we broke something there but I do not know. @kunjdedhia @imnnos any ideas about this? I'll try to check it out tomorrow.

ygbull commented 2 years ago

@ygbull Yeah that isn't our team's file, it is possible that we broke something there but I do not know. @kunjdedhia @imnnos any ideas about this? I'll try to check it out tomorrow.

Yeah, it happens. It should be solvable by either making the int into double or the other around. Just make sure it's compilable.

tomking commented 2 years ago

Ah gotcha, I'm on my phone so I didn't look at the file. We will get it fixed and committed here.

ygbull commented 2 years ago

Sounds good @tomking

tomking commented 2 years ago

Alright @ygbull I think that is what we are going with for now. Hopefully that doesn't break anything else, we will have to be in touch with Fisher's Fish about it... @nategreb @Sad-0w see latest commit to this PR. We don't want people to be able to set floating point numbers as the min/max of a range for an RNG, only ints. Thank you all for continuing to work with us on all of this.

tomking commented 2 years ago

Any feedback from Team Team @sasana-uwu @SiegAndy ?

Or anything of note from Fisher's Fish @nategreb @Sad-0w ?

And any progress on the stuff you were talking about doing on Slack @userazhao ? I don't think there is any reason that work couldn't just be done after this is merged in as long as you don't have any objections to this PR.

imnnos commented 2 years ago

Any feedback from Team Team @sasana-uwu @SiegAndy ?

Or anything of note from Fisher's Fish @nategreb @Sad-0w ?

And any progress on the stuff you were talking about doing on Slack @userazhao ? I don't think there is any reason that work couldn't just be done after this is merged in as long as you don't have any objections to this PR.

+1. We need to go ahead and get this PR merged so that integration can move forward after the meeting tomorrow.

nategreb commented 2 years ago

@Sad-0w See above comment: "We don't want people to be able to set floating point numbers as the min/max of a range for an RNG, only ints." They modified it to ints.

tomking commented 2 years ago

@nategreb Does that change cause major issues for you guys?

nategreb commented 2 years ago

@nategreb Does that change cause major issues for you guys?

No, it doesn't. Go ahead and merge.

tomking commented 2 years ago

@nategreb Does that change cause major issues for you guys?

No, it doesn't. Go ahead and merge.

Okay awesome, thank you for the feedback. Would you mind giving the PR an approval in that case?

(Just a note as well, we are still waiting for Team Team to give us any input)