davidgohel / ReporteRs

Note that ReporteRs has been removed from CRAN the 16th of July 2018 and is not maintained anymore. please migrate to officer.
245 stars 44 forks source link

Java 10 compatibility #225

Closed MatthiasHinz closed 5 years ago

MatthiasHinz commented 6 years ago

Did you test the package with the latest Java Runtime (10.0.1)? When I tconfigured R to use java 10 and tired to create / write a docx, it caused me the following error in R:

java.lang.NoClassDefFoundError: javax/xml/bind/JAXBException

I figured out that the corresponding libraries are seemingly not included in Java SE starting from 0. Therefore it would have to be linked to the dependencies.

https://stackoverflow.com/questions/43574426/how-to-resolve-java-lang-noclassdeffounderror-javax-xml-bind-jaxbexception-in-j/46455026

davidgohel commented 6 years ago

Yes, I know. I wrote a note on the README page :

ReporteRs has been rewritten. The new package is officer. FlexTable objects are now implemented in package flextable. Vector graphics are now implemented in package rvg and Native Microsoft charts can be produced with package mschart.

Please use officer instead of ReporteRs. There are issues when using java > 1.8 that won’t be fixed.

Also I added another note at the top of the github page of ReporteRs saying:

ReporteRs will be removed from CRAN the 16th of July. please migrate to officer

Also I've deprecated pptx() and docx() in the github version.

At this stage, I must say I don't know what else could be done to warn people... Any suggestions??

KR David

MatthiasHinz commented 6 years ago

Well... no suggestions. I think it should be obvious to those who re-read the documentation. Thank you!

MatthiasHinz commented 6 years ago

But if it's really a problem that people frequently overlook this matter, you could still change the formatting in the documentation note to red bold text, add a red frame, or include an attention image like this: https://pixabay.com/en/important-attention-1702878/