Multiple Fixes: Default height, ability to change zoom and vue2-leaflet upgrade

davidpiesse / nova-map

Laravel Nova Map Field

114 stars 29 forks source link

Multiple Fixes: Default height, ability to change zoom and vue2-leaflet upgrade #11

Closed bomshteyn closed 5 years ago

bomshteyn commented 5 years ago

While configuring the plugin for my use case i have run into few issues

if not setting ->height() the map was not showing up at all as the default height of 300px was only being set if the ->height() was called but without a param
needed ability to zoom in to street level by default

This pull request fixes both of these plus upgrades underlying vue2-leaflet

bomshteyn commented 5 years ago

@davidpiesse the reason i am calling the zoom method after fitBounds is because fitBounds doesn't respect zoom property and was setting it to maxZoom.

So for example if the initial zoom was set to 8 and maxzoom inside the fitBounds function was passed as 16 it would change the zoom to 16.

Zen0x7 commented 5 years ago

Nice dude! 🎉🎉🎉

édít This will reduce too much my app load time...

davidpiesse commented 5 years ago

Hi there!

Thanks for this. Been very busy recently with paying work so have not had time to merge in these changes. I am monitoring it and it all makes sense.

Hopefully I can bring it in soon 😄

bomshteyn commented 5 years ago

Hi, any timeline on this?