davidpiesse / nova-map

Laravel Nova Map Field
114 stars 29 forks source link

Replace grimzy/laravel-mysql-spatial by matanyadaev/laravel-eloquent-spatial #40

Open vesper8 opened 2 years ago

vesper8 commented 2 years ago

It's become pretty clear that grimzy/laravel-mysql-spatial is abandoned and there's been a migration to matanyadaev/laravel-eloquent-spatial which is actively maintained, does everything that grimzy/laravel-mysql-spatial did and is future proof (supports Laravel 9 and PHP 8.1.

I personally just migrated a rather large project from grimzy/laravel-mysql-spatial to matanyadaev/laravel-eloquent-spatial and am happy to report the migration was very easy and quite painless, taking me only about 1 hour including testing that everything still works.

My only dependence on grimzy/laravel-mysql-spatial now is your package here, which I find very useful and am glad for.

On that note, it would be truly fantastic if you also migrated to matanyadaev/laravel-eloquent-spatial : )

I think you will find it quite easy and simple to do so.

Many thanks for the consideration!

pelmered commented 2 years ago

Same situation here.

davidpiesse commented 2 years ago

Thanks for the suggestion.

I am waiting for Nova 4 to launch tomorrow before making any improvements. This package may receive an update shortly.

If you want to PR a update I would be happy to include the change. The ability to remove grimzy would be nice.

D

sutcliffe121 commented 2 years ago

Although it's a required dependency, I don't think the grimzy/laravel-mysql-spatial package is actually used in the current package version? The only reference I can find is a function that is commented out in src/Map.php

image

davidpiesse commented 2 years ago

Could you submit a PR with the package removed? It does look like it was only used for a planned editing functionality, which was not yet implemented.