daytonamelia / Deduper-daytonamelia

Deduper assignment for BGMP Bi624
1 stars 0 forks source link

peer review #2

Open laurenrw12 opened 1 month ago

laurenrw12 commented 1 month ago

Hello!

Great work on your pseudocode!! I was able to follow your logic and everything makes sense to me! I believe your algorithm does everything it is supposed to do.

I really like your "softclip_corrector" function. I think it helps with the flow of the code to have that separate from the main code chunk.

Something to think about ... if the read is on the minus strand, will you have to reverse complement the umi?