search

dbeck121 / CPI-Helper-Chrome-Extension

59 stars 20 forks source link

bug-fix commits #104

Closed Incpi closed 1 year ago

Incpi commented 1 year ago

Hello @dbeck121 once again,

Cleaned-up code for #103 - closed because my issue with git. Do let me know if you found any issue. apart from Clipping Text - unrestricted width in Last visited section. (Fix - maybe in future.).

for this PR, in brief,

Done with issues. You can merge it if you want. @fippu82 Thank you for your help. let me know if you found any other bug. I don't have anything else to add it for now. Thank you for being patient with me. good day.

Thanks, Omkar

fippu82 commented 1 year ago

@incpi, thank you! I have one more small design issue: It's not intuitively clear what the status of this toggle button is:

image

It should clearly reflect the current status. E.g. like this: https://www.freepik.com/icon/toggle-button_5720465

Otherwise, the word on the button could mean the current status but as well could indicate the status after clicking it. Do you mind to change this?

Incpi commented 1 year ago

Thank you for your feedback. I have revised the text to read "Set as \<Action>". You may wonder why I did not use icons instead. The reason is that icons do not fit well with the UI default component. I tried using icons at first, but they looked unappealing to me. So, I decided to use text instead.

I hope now, this clears up confusion of UI also the intent of buttons.

fippu82 commented 1 year ago

@incpi That does the trick as well, thank you! One more thing: I notice that text links on CPI pages are colored green, like this:

image

Was that intended?

Incpi commented 1 year ago

@fippu82 ,

No it's not intended. Sorry, that was my mistake. I was testing a new design. You can remove popup.css from the manifest file or you can try along with this current pr. I fixed a lot of issues and added new features in this Pr. One of the reasons I rushed this PR bit Lot of broken things in prev PR.

Hope this helps. BR, Omkar

dbeck121 commented 1 year ago

Hi, thanks for the development! I will test and it will be probably part of next release! :-)

dbeck121 commented 1 year ago

@incpi I checked it and works great! It will be part of next release. It makes CPI Helper a little bit better and a lot nicer. Thank you so much for your effort! The CPI Community will thank you!