search

dbeck121 / CPI-Helper-Chrome-Extension

53 stars 18 forks source link

Update contentScript.js #155

Closed FarihaAli closed 4 months ago

FarihaAli commented 4 months ago

No messages are displayed if there are dangling RETRY msgs from the past with no LogStart or LogEnd ie null e.g Dangling msg as below: image It stops all the messages from being displayed

Earlier a change was suggested and RETRY msgs were discarded but that impacted other tenants, to have no impact the code now uses LogStart gt datetime'1900-01-01T01:02:50' which is from long past and will remove RETRY msgs with LogStart as null

fippu82 commented 4 months ago

Thank you for the explanation and the fix! Now it's clear what the previous changer of this function was trying to achieve.

jonprow commented 4 months ago

@dbeck121 When can we merge this change?

dbeck121 commented 4 months ago

Great! Thanks!