location of sidebar - Githubissues

dbeck121 / CPI-Helper-Chrome-Extension

58 stars 20 forks source link

location of sidebar #173

Closed fippu82 closed 6 months ago

fippu82 commented 6 months ago

To prepare for future SAP UI changes (already live on Neo), we should move the sidebar down (can already be done, no negative impact). Also I move it a bit to the left as it always covered the zoom and navigator buttons (rarely used by most, but was unclean nevertheless).

More changes to come for color etc., see https://github.com/dbeck121/CPI-Helper-Chrome-Extension/issues/172.

fippu82 commented 6 months ago

Actually we should create a new branch for this (at least for the other UI related adaptations), not a PR yet...

dbeck121 commented 6 months ago

Good idea... Maybe in general we should start using branches more

fippu82 commented 6 months ago

Feature branches would make sense for bigger topics. Otherwise, @DevGregor just told me that we can create PRs in draft status. Then it can be reviewed and still extended. Also an option.