Closed DevGregor closed 3 months ago
Hi @DevGregor and @dbeck121. You may need to pay attention to this.
as I already stated (Solution appears straightforward but is intricate) #172 ,
Fomantic UI issue: This will likely be a major change. For example, our Fomantic UI won't be ready for use in dark mode if SAP officially supports dark themes or the Dark CPI plugin does. One approach is to "inverted" the classes, although I am bit skeptical.
SAP Theme support: We must use extensive CSS to adjust the SAP theme, SAP light theme also handles a few colors in the CPI Helper.
I have no other or bypass method for doing this.
For now, I hope this explanation is helpful. Please visit the Discord server (Design-discussions) where I posted my suggestion. I much value your feedback.
Thank you. Omkar
I finally understand a bit more what the issue here is. By default we have a white background and white text but if I choose a color the aforementioned color issues are "fixed":
Fixed with #179
Thanks! Super nice how fast you are! Amazing to work with you!
Describe the bug Some coloring needs to be fixed in the upcoming version (4.0.0).
To Reproduce Steps to reproduce the behavior:
Expected behavior Some text, labels and icons are not visible unless highlighted or hovered.
Screenshots Current look: Highlighted:
Current look: Hovered: Hovered: Clicked:
Version 4.0.0
Desktop:
Tenant type:
Additional Info: The browseraddon Dark CPI was turned off when checking this just to make sure this wasn't caused by it since some other coloring issues are affected by that addon. Posted issue there as well: https://github.com/incpi/Dark-CPI-Web-Extension/issues/5