Color Issue Fix

[DevGregor]

• Fixes color issues especially for users who don't have any tenant color set (e.g. if CPI Helper was freshly installed)
• The default/reset color is set to white so it matches with what the header bar of the new CPI UI
• Tenant Color selection works as usual. I just generally changed the text color to black since the default background color is white
• The default background color of buttons is lightblue if no tenant color was set
• What's New Popup Header and Info Popup Header have now black text color and are visible if no tenant color was set

[DevGregor]

changed the default button background to this (same color as in the gray tenant color option):

[DevGregor]

Made fixed text color for the outerFrame in the message sidebar (fixes issues e.g. when SAP Dark CPI Addon overwrites it):

[DevGregor]

Hello @incpi I have almost no issues when using both CPI Helper and SAP Dark anymore with this PR but there is one thing that still needs to be fixed...

CPI Helper sets the background color (in default tenant color white) and SAP Dark sets the text color (evening horizon) of the tool header. Becuase both colors are very bright it looks like this:

SAP Dark seems to set the background color before CPI Helper does it, thus, CPI Helper will overwrite the background color of SAP Dark resulting in what you can see on the screenshot above.

How should we go about this? I guess in CPI Helper we need to set the text color to black by default?

[dbeck121]

@DevGregor I would go with setting black as default.

I pull to have this in the new 3.13.0 version.

[incpi]

Hello @DevGregor / @dbeck121,

We might need to revert this

This Fix has bugs as you mentioned, additionally I don't think this a good way to fix it. it is totally work around not a proper solution.

      if(color == "#ffffff"){
        root.style.setProperty('--button-active-color', "#767676");
      }else{
        root.style.setProperty('--button-active-color', color);
      }

here let's say i am doing a #fffffe then?

<div id="outerFrame" style="color: black;"> // see below mention issues..

issues

• Dark mode (with header color as black)

We can't directly go with black here. Hold till these fixes are done. Thanks Omkar

[DevGregor]

Hello @DevGregor / @dbeck121,

We might need to revert this

This Fix has bugs as you mentioned, additionally I don't think this a good way to fix it. it is totally work around not a proper solution.

     if(color == "#ffffff"){
       root.style.setProperty('--button-active-color', "#767676");
     }else{
       root.style.setProperty('--button-active-color', color);
     }

here let's say i am doing a #fffffe then?

<div id="outerFrame" style="color: black;"> // see below mention issues..

issues

• Dark mode (with header color as black)

We can't directly go with black here. Hold till these fixes are done. Thanks Omkar

Hello @incpi But we removed the black tenant color option? At least in the current DEV it is already removed.

[incpi]

we can set via option by selection right...

[DevGregor]

Here the color options by version: 1.12.1 (current) 1.13.0