dbeck121 / CPI-Helper-Chrome-Extension

56 stars 19 forks source link

Dark mode - For Test #196

Closed Incpi closed 1 month ago

Incpi commented 2 months ago

Hello All,

This will be the pull request for the dark mode feature. I would greatly appreciate it if you could try it out and provide your valuable feedback.

I am writing custom lib based on fomantic-Ui (works with this project only). Small preview: image

Make a separate branch if needed.

Thank you. Omkar

dbeck121 commented 2 months ago

Hi,

sorry that you have to wait for so long. I will check this weekend!

dbeck121 commented 2 months ago

@incpi

can you give a bit background:

In general: works prety good so far.

Incpi commented 2 months ago

Hello @dbeck121,

I'm altering it as I discovered it. Since I wrote my custom CSS (not perfect at all). I also included small dev notes (readme.md) in each lib that I make changes as disclaimer/ warning to be aware of impact of changes in future.

If you need more info, let me know. Thanks Omkar

fippu82 commented 2 months ago

Hi @incpi,

I have pulled your changes and while using CPI Helper with Inline Trace, I encountered a bug: After deactivating inline trace (using the button in the sidebar), it is still opening the log popup when clicking on a step that was part of the trace.

Could you please check this as it works in the currently published version. Thanks!

Incpi commented 2 months ago

Actually, @dbeck121 / @fippu82.

It doesn't affect the current version because I made a mistake in the 3.15 version. If you plan to release version 15, kindly include this roughly every 15 lines. I appreciate you informing me of this. I completely forgot about it. I fixed the last commit in this PR.

Regards

fippu82 commented 2 months ago

@incpi Thank you. But what do you mean by "kindly include this roughly every 15 lines."? I don't get you.

Incpi commented 2 months ago

@incpi Thank you. But what do you mean by "kindly include this roughly every 15 lines."? I don't get you.

This fix, or last commit from this PR

for 3.15 version. If any planned for release, we need to add these changes there. So no impact in current dev version