search

dbeck121 / CPI-Helper-Chrome-Extension

58 stars 20 forks source link

Update theme-color in the setHeaderColor function #91

Closed JensWallgren closed 1 year ago

JensWallgren commented 1 year ago

A small feature that I wanted myself. I like the idea of using Integration Suite via the "fake app" / "create shortcut" feature of Chrome. This way, it Integration Suite masquerades as an "actual app/program" on my computer. For a tool I might sit with all day it makes sense to have it in its separate app-like window, rather than it getting lost amongst all my browser tabs.

Either way, the "theme-color" tag / feature controls the way the "OS header" is colored. So I felt like implementing this. It's also in general a tag that does exactly what it sounds like - signalizes the theme-color of the current website to the browser that is running it. MSDN Documentation

I added a small piece of logic that updates the "theme-color". It gets updated along with the UI5 header color in the "setHeaderColor" function. Gives the full window top a nice, unified look, and further separates different environments from each other.

JensWallgren commented 1 year ago

A screenshot to visualize this.

On the left is the current main branch, on the right is the window as seen with the extra functionality of my PR.

image

dbeck121 commented 1 year ago

Nice, thanks for the contribution. Looks nice :-) I will mention you in the next release!

JensWallgren commented 1 year ago

Cool! Thanks for the rest of the extension! :)