dbpedia / dbpedia-chatbot-backend

4 stars 0 forks source link

Update code from the GSoC 2022 project repo #5

Closed Perevalov closed 1 year ago

Perevalov commented 1 year ago

Source repo: https://github.com/UditArora2000/GSoC2022_Question_Answering

ToDo:

muskan-k commented 1 year ago

@Perevalov created the release and tag. I've saved the draft in releases. If that's correct, let me know if I should publish the release. About removing outdated links to GSoC 2022 and previous year's contributions - you mean the links on readme file(s) correct?

Perevalov commented 1 year ago

@Perevalov created the release and tag. I've saved the draft in releases. If that's correct, let me know if I should publish the release. About removing outdated links to GSoC 2022 and previous year's contributions - you mean the links on readme file(s) correct?

Yes, just publish the release s.t. it is visible in the repo. Regarding the links -- correct.

muskan-k commented 1 year ago

@Perevalov I'm done with this task. Also, I would normally create a new branch and make a PR for any requested change. However, since this was a task updating existing code from old to new, I just wanted to clear that I did not make a PR for this. However, if you say so, I can revert the commit and make a PR for updating the code from gsoc-22.

Perevalov commented 1 year ago

@Perevalov I'm done with this task. Also, I would normally create a new branch and make a PR for any requested change. However, since this was a task updating existing code from old to new, I just wanted to clear that I did not make a PR for this. However, if you say so, I can revert the commit and make a PR for updating the code from gsoc-22.

No problem, for now we'll push directly in main. When we stabilize the codebase, we will create tests and CI/CD and protect the main branch

Perevalov commented 1 year ago

@muskan-k there are two "RDF Vizualization" folders. Could you make a comparison of them and remove one. I suppose the old one should go and the new one stays

muskan-k commented 1 year ago

Done, just deleted the older one. @Perevalov

@muskan-k there are two "RDF Vizualization" folders. Could you make a comparison of them and remove one. I suppose the old one should go and the new one stays

Perevalov commented 1 year ago

@muskan-k thanks for your contribution!