search

dbrock / bongo

Play music with GNU Emacs
http://www.emacswiki.org/emacs/Bongo
Other
210 stars 22 forks source link

Minimum Emacs version supported #29

Closed iqbalansari closed 8 years ago

iqbalansari commented 9 years ago

I was trying to cleanup Bongo code since emacs lisp byte compiler right now reports a lot of warnings. While doing so there were multiple occurrences of the following warning

Warning: interactive-p is an obsolete function (as of 23.2); use `called-interactively-p' instead.

I was wondering what is the minimum version Bongo intends to support, is it okay if I change calls to interactive-p to called-interactively-p (and break compatibility with Emacs 23.2)?

dbrock commented 9 years ago

Thanks for bringing this up. I appreciate the effort to clean up the compilation warnings.

It used to be that we supported GNU Emacs all the way back to version 21.1, but that code was moved into a separate file many years ago and subsequently dropped altogether. Since then, I believe 22.1 is the oldest version we've been supporting. But seeing as how that's now almost a decade old, I think we can safely bump the minimum version up to at least 23.4 (released in January 2012, nearly four years ago).

So I say go ahead and change those calls.

Let me know if you run into anything else like this. I wouldn't mind restricting support even further if necessary.

iqbalansari commented 9 years ago

Thanks for your clarification. I will work on it, this weekend. Looking at Emacs release history, Emacs v24.1 and Emacs v23.4 were separated by just 4 months. I would suggest we drop compatibility for Emacs v23, your thoughts?

thomas-louvigne commented 9 years ago

agree.

Thomas Luquet mail : thomas@luquet.net

On Thu, Nov 12, 2015 at 3:25 PM, Iqbal Ansari notifications@github.com wrote:

Thanks for your clarification. I will work on it, this weekend. Looking at [Emacs release history)[https://www.gnu.org/software/emacs/history.html], Emacs v24.1 and Emacs v23.4 were separated by just 4 months. I would suggest we drop compatibility for Emacs v23, your thoughts?

— Reply to this email directly or view it on GitHub https://github.com/dbrock/bongo/issues/29#issuecomment-156115176.

dbrock commented 8 years ago

Fine by me.