search

dbrock / bongo

Play music with GNU Emacs
http://www.emacswiki.org/emacs/Bongo
Other
207 stars 22 forks source link

Fix byte compilation warnings #31

Closed iqbalansari closed 8 years ago

iqbalansari commented 8 years ago

This fixes most of the byte compilation warnings (on Emacs 24.5) except for the use of filter-buffer-substring-functions but we can't do much in that case since we support Emacs 24.1 where the alternative filter-buffer-substring-function is not available.

I have intentionally spread this over a set of commits so that they can be reviewed independently, will squash them if needed.

Do not merge this yet, I want to test this for sometime to make sure I have not introduced any regression (unlikely).

Fixes #29

dieterdeyke commented 8 years ago

Iqbal Ansari notifications@github.com writes:

This fixes most of the byte compilation warnings except for the use of filter-buffer-substring-functions but we can do much in that case since we support Emacs 24.1 where the alternative filter-buffer-substring-function is not available. ...

  • Require dired, before using its functions ...

Since dired is now required, can I get my own little private keybinding into the upstream master?

(define-key dired-mode-map (kbd "b") 'bongo-dired-library-mode)

Thanks,

Dieter Deyke mailto:dieter.deyke@gmail.com Get my Gnupg key: gpg --keyserver keys.gnupg.net --recv-keys B116EA20

iqbalansari commented 8 years ago

I have been using this for some time and looks to be working fine, so I guess this can be merged.

@dieterdeyke Perhaps you can open a pull request with the change

Thanks

iqbalansari commented 8 years ago

@dbrock Hi, any update on this?

dbrock commented 8 years ago

Sorry for the delay, and thanks for doing this work @iqbalansari.

dbrock commented 8 years ago

@dieterdeyke I don't know if it's a good idea to silently redefine keys in other modes like that, although I agree it is a nice binding. Do you know if any other packages do something similar?

By the way, I wish they would go ahead and bind r to wdired-change-to-wdired-mode already. Seems like everyone is using that binding anyway.

dieterdeyke commented 8 years ago

Daniel Brockman notifications@github.com writes:

@dieterdeyke I don't know if it's a good idea to silently redefine keys in other modes like that, although I agree it is a nice binding. Do you know if any other packages do something similar?

No, I don't know of any other package doing that.

By the way, I wish they would go ahead and bind r to wdired-change-to-wdired-mode already. Seems like everyone is using that binding anyway.

+1

Dieter Deyke mailto:dieter.deyke@gmail.com Get my Gnupg key: gpg --keyserver keys.gnupg.net --recv-keys B116EA20