search

dbrock / bongo

Play music with GNU Emacs
http://www.emacswiki.org/emacs/Bongo
Other
207 stars 22 forks source link

Stop bongo player when bongo buffer or track is deleted #42

Closed iqbalansari closed 7 years ago

iqbalansari commented 7 years ago

This pull request update Bongo to

1) Stop the currently playing track, if the line containing the track is deleted Otherwise to stop the track, the user needs to switch to another track and stop it 2) Stop the currently playing track, if the Bongo buffer is deleted Otherwise the user has no way to stop the track other than killing the external music player by other means

dbrock commented 7 years ago

Actually you can still stop a track after killing it using C-c C-s, right?

In any case, this makes sense to me.

Thanks for the nicely formatted patches! 👍

iqbalansari commented 7 years ago

Yes you are right, C-c C-s works too. It just feels a bit more intuitive if the track if stopped after deleting it. Thanks for the quick merges :smile:

dbrock commented 7 years ago

On second thought, I don't know if I like this.

I remember specifically wanting to let the user kill and yank tracks at will without disturbing playback.

What if you are just moving tracks around? I hate when music players interrupt playback unnecessarily.

However, asking to stop playback when you kill the entire buffer does make sense to me still.

Thoughts?

iqbalansari commented 7 years ago

You are right, actually I forgot about the use case of moving tracks around. I think we should revert that change :+1:.

iqbalansari commented 7 years ago

I meant we can revert e4ef3a27a029e9eded2f29c1dae1a3b01bf892e9.

dbrock commented 7 years ago

:+1:

Why doesn't GitHub let you revert things from the web UI? So silly!