search

dbrock / bongo

Play music with GNU Emacs
http://www.emacswiki.org/emacs/Bongo
Other
207 stars 22 forks source link

Backend for MPV player #45

Closed iqbalansari closed 5 years ago

iqbalansari commented 7 years ago

This pull request adds a backend to play files using mpv. Bongo communicates with mpv using mpv's JSON IPC described here. It is a mostly straightforward use of the protocol, passing commands and reading responses over a UNIX socket. I have opted to poll for the track time at regular intervals instead of using the observe_property to get notified of it, since the mpv seems to be generating a lot of events for track times and I am not sure Emacs can handle those many events efficiently.

dbrock commented 6 years ago

Hey @dieterdeyke do you think we should merge this? You're almost a Bongo maintainer at this point

dieterdeyke commented 6 years ago

Daniel Brockman notifications@github.com writes:

Hey @dieterdeyke do you think we should merge this? You're almost a Bongo maintainer at this point

I am not using mpv myself, so I cannot say if the code does work, but it looks to be well written, and since it is just additions without changes to existing code, I would say yes.

-- Dieter Deyke mailto:dieter.deyke@gmail.com Get my Gnupg key: gpg --keyserver keys.gnupg.net --recv-keys B116EA20

hyiltiz commented 5 years ago

Since it has no conflics, could you merge this please? I would very much like to use mpv as the backend (I'd rather not install mplayer or vlc to my system to keep redundancy low).

dbrock commented 5 years ago

Thanks guys