dbrock / bongo

Play music with GNU Emacs
http://www.emacswiki.org/emacs/Bongo
Other
207 stars 22 forks source link

Adaptation for mpv's argument parser changes #53

Closed nagy closed 3 years ago

nagy commented 4 years ago

According to this commit0 mpv now requires an equal sign between the parameters and their arguments.

Gleek commented 3 years ago

Hey @dieterdeyke @dbrock do you think this should be merged? mpv player fails to play with Process ‘bongo-mpv’ exited abnormally with code 1 without this change.

cc @iqbalansari since you added mpv as a backend

Gleek commented 3 years ago

Actually, I noticed another error popping up in mpv when changing the song, with this change.

Error running timer ‘bongo-mpv-player-tick’: (file-error "make client process failed" "Connection refused" :name "bongo-mpv" :buffer nil :family local :service "/var/folders/f3/j94kxrl177b_fn9gzqkytwgw0000gp/T/bongo-mpv.socket" :filter bongo--mpv-socket-filter) [2 times]

This doesn't seem to be causing any loss in functionality though.

emacs-version : GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin19.6.0, NS appkit-1894.60 Version 10.15.6 (Build 19G73)) of 2020-09-11

~ mpv --version
mpv 0.32.0 Copyright © 2000-2020 mpv/MPlayer/mplayer2 projects
 built on Tue Jun 16 15:58:50 BST 2020
ffmpeg library versions:
   libavutil       56.31.100 (runtime 56.51.100)
   libavcodec      58.54.100 (runtime 58.91.100)
   libavformat     58.29.100 (runtime 58.45.100)
   libswscale      5.5.100 (runtime 5.7.100)
   libavfilter     7.57.100 (runtime 7.85.100)
   libswresample   3.5.100 (runtime 3.7.100)
ffmpeg version: 4.3.1
dbrock commented 3 years ago

Okay, merging this. Thanks for the patch.

crzjp commented 2 years ago
Error running timer ‘bongo-mpv-player-tick’: (file-error "make client process failed" "Connection refused" :name "bongo-mpv" :buffer nil :family local :service "/var/folders/f3/j94kxrl177b_fn9gzqkytwgw0000gp/T/bongo-mpv.socket" :filter bongo--mpv-socket-filter) [2 times]

I'm witnessing this same error. How did you solve?

Gleek commented 2 years ago

I'm witnessing this same error. How did you solve?

I haven't. They come up a few times and then the song plays automatically.