search

dbrock / bongo

Play music with GNU Emacs
http://www.emacswiki.org/emacs/Bongo
Other
210 stars 22 forks source link

bongo-mpv: bongo calling mpv with badly formed option #61

Open abhiseck opened 1 year ago

abhiseck commented 1 year ago

I'm using bongo (version 1.1) with mpv backend. My mpv version is: 0.35.1. Trying to play any media with mpv backend would fail with 1 status. I investigated the issue a little and discovered that bongo is calling mpv with:

mpv --input-ipc-server <socket-file> <other-options> <file-name>

but mpv requires that long options be in the following form: --long-options=value and not int the form --long-option value. So mpv should be called this way:

mpv --input-ipc-server=<socket-file> <other-options> <file-name>

I'd be really greateful if you fix this.

For now here's a quick and dirty fix. Put the following in your init.el:

(defun my-bongo-compose-remote-option (socket-file)
  (list (concat "--input-ipc-server=" socket-file)))

(advice-add 'bongo-compose-remote-option
            :override #'my-bongo-compose-remote-option)