decker-edu / decker

A markdown based tool for slide deck creation.
GNU General Public License v3.0
60 stars 15 forks source link

Recording Tab Selection is now handled differently by browsers #58

Closed salbeira closed 1 year ago

salbeira commented 1 year ago

In the most recent chrome version on Windows I can only choose the current tab as a video stream source. There is no option to pick a different tab, window or screen.

In the most recent chrome version on Linux I can NOT choose the current tab as a video stream source. Everything BUT the current tab is an option.

Using the current develop branch.

EDIT: This even happens with the old 0.12 version.

Can anyone confirm this?

salbeira commented 1 year ago

Seems like the newest browser versions are now enforcing some changes propsed last year:

The browser will, by default, hide the current tab from selection so that WebRTC applications do not have a "hall of mirrors" effect when opening the selecion interface. You need to specify "selfBrowserSurface: 'include'" in the getDisplayMedia()-options to have the current tab available for sharing.

In addition, "preferCurrentTab", under Windows, displays an entriely different interface that ONLY presents the current tab:

grafik

salbeira commented 1 year ago

Some more screenshots:

Without "preferCurrentTab" and without "selfBrowserSurface":

grafik

With selfBrowserSurface:

grafik

mbotsch commented 1 year ago

Should be fixed in master branch and develop branch. Could you please test it on Linux and Windows?

monofon commented 1 year ago

Someone please test this with the released v0.13.4 on Windows.

salbeira commented 1 year ago

Tested on both Windows and Linux on both master and develop built from source. Also tested it with the executable inside the releases. I can select the decker-tab as a source (and have the usual selection of window and screen again) Closing the issue.