Menu and Feedback Plugin get initialised in print mode

decker-edu / decker

A markdown based tool for slide deck creation.

GNU General Public License v3.0

55 stars 14 forks source link

Menu and Feedback Plugin get initialised in print mode #60

Closed salbeira closed 9 months ago

salbeira commented 9 months ago

The menu and feedback plugin should just not be initialised if we print a pdf so the menu containers are never even added to the DOM. This should make it impossible for the elements to creep into the printed page in any way.

mbotsch commented 9 months ago

The bug Daniele reported was already fixed in commit 8cf3ec2bf82d6c8049f8bc2cdddaeee1d55858f0

salbeira commented 9 months ago

Hmh yes but wouldn't this also future proof the issue against other changes to css rules?